Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling users from adding SSH keys #24716

Closed
panangam opened this issue May 14, 2023 · 3 comments · Fixed by #29447
Closed

Allow disabling users from adding SSH keys #24716

panangam opened this issue May 14, 2023 · 3 comments · Fixed by #29447
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone

Comments

@panangam
Copy link

Feature Description

It would be great if we have the option to disable SSH key adding by users, for when keys are entirely externally managed by an admin. Seems like removing the front end button is easy enough using a template, but from my understanding, to be secure we will also need to disable the API endpoint. I don't think such a feature exists right now.

In my mind, an implementation could be to

  1. Add an SSH configuration option to "allow non-admin users to add SSH keys" (default to true).
  2. Make the front end check for this setting and set the "Add SSH Key" button to disabled.
  3. Make the api endpoint check this setting.

Would this be a good idea? Or is there a configuration to achieve this already? If this will be a good contribution, I plan to make a PR of it.

Issue #13983 seems relevant, but it only deals with deleting keys.

(I have asked this on Discord and was advised to make a proposal here)

Screenshots

No response

@panangam panangam added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels May 14, 2023
@panangam
Copy link
Author

@wxiaoguang Oras from discord here :).

@wxiaoguang
Copy link
Contributor

It seems related to #20549

@lunny lunny modified the milestones: 1.22.0, 1.23.0 Feb 27, 2024
lunny added a commit that referenced this issue Mar 4, 2024
…ce on app.ini (#29447)

Follow #29275
Extract from #20549
Fix #24716

---------

Co-authored-by: delvh <dev.lh@web.de>
@lunny lunny modified the milestones: 1.23.0, 1.22.0 Mar 4, 2024
@panangam
Copy link
Author

panangam commented Mar 4, 2024 via email

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants