Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement actions log line anchor so that it's easy to jump to a special log line #24593

Closed
lunny opened this issue May 8, 2023 · 0 comments · Fixed by #25532
Closed

Implement actions log line anchor so that it's easy to jump to a special log line #24593

lunny opened this issue May 8, 2023 · 0 comments · Fixed by #25532
Labels
good first issue Likely to be an easy fix topic/gitea-actions related to the actions of Gitea type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@lunny
Copy link
Member

lunny commented May 8, 2023

Feature Description

图片

Screenshots

No response
@lunny lunny added type/proposal The new feature has not been accepted yet but needs to be discussed first. type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/enhancement An improvement of existing functionality topic/gitea-actions related to the actions of Gitea and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels May 8, 2023
@a1012112796 a1012112796 added the good first issue Likely to be an easy fix label May 9, 2023
@HesterG HesterG mentioned this issue Jun 13, 2023
Closed
@HesterG HesterG mentioned this issue Jun 27, 2023
Merged
techknowlogick pushed a commit that referenced this issue Jul 3, 2023
@HesterG @silverwind @wxiaoguang
Add log line anchor for action logs (#25532)
640a88f 
Close #24593

Some behavior:

- If log step line in hash exists, expand the step and scroll to the log
line.
- If step exists but line not exists, the step will be expanded.
- If step not exists, stays on the job's page.

Some Notes:

- Changed mounted to async because need to await for first `loadJob` so
`currentJobStepsStates` can be initialized and used in
`hashChangeListener `.

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Likely to be an easy fix topic/gitea-actions related to the actions of Gitea type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add log line anchor for action logs HesterG/gitea
2 participants
@lunny @a1012112796