Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

?go-get=1 not working if REQUIRE_SIGNIN_VIEW = true #2333

Closed
2 of 7 tasks
sulliwane opened this issue Aug 18, 2017 · 7 comments
Closed
2 of 7 tasks

?go-get=1 not working if REQUIRE_SIGNIN_VIEW = true #2333

sulliwane opened this issue Aug 18, 2017 · 7 comments
Labels
type/question Issue needs no code to be fixed, only a description on how to fix it yourself.

Comments

@sulliwane
Copy link

  • Gitea version (or commit ref): 1.1.3
  • Operating system: Ubuntu server 16.04
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No, I can't change the app.ini settings
    • Not relevant

Description

?go-get=1 not working on repo url, if REQUIRE_SIGNIN_VIEW = true in app.ini, because redirected to login page
@strk
Copy link
Member

strk commented Aug 18, 2017

What would you expect to happen ?
Doesn't the ?go-get=1 response count as view ?

@sulliwane
Copy link
Author

I have my login/password stored in a ~/.netrc, which let me go get my.gitea.com/private/repo <- PRIVATE REPO.

The problem is that, if REQUIRE_SIGNIN_VIEW = true is enabled, the behavior described above doesn't work anymore.

I'm not 100% sure about the meaning of the REQUIRE_SIGNIN_VIEW option, but I think it should not make go get private/repo stop working...

Is it the same issue as this one : gogs/gogs#1878 ?

@strk
Copy link
Member

strk commented Aug 18, 2017 via email

@lafriks
Copy link
Member

lafriks commented Aug 18, 2017

I think @bkcsoft fixed this in gitea master also

@lafriks lafriks added the type/question Issue needs no code to be fixed, only a description on how to fix it yourself. label Aug 18, 2017
@lafriks
Copy link
Member

lafriks commented Aug 18, 2017

I think this is fixed with #2010

@bkcsoft
Copy link
Member

bkcsoft commented Aug 19, 2017

Yeah it's fixed in #2010, though hasn't been backported to 1.1.x

@lafriks
Copy link
Member

lafriks commented Aug 19, 2017

I'm closing issue than. It will be fixed with 1.2.0 release

@lafriks lafriks closed this as completed Aug 19, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
6543 pushed a commit to 6543-forks/gitea that referenced this issue Feb 26, 2024
@Gusted
[BUG] Workaround borked Git version
f68f880 
- In Git version v2.43.1, the behavior of `GIT_FLUSH` was accidentially
flipped. This causes Forgejo to hang on the `check-attr` command,
because no output was being flushed.
- Workaround this by detecting if Git v2.43.1 is used and set
`GIT_FLUSH=0` thus getting the correct behavior.
- Ref: https://lore.kernel.org/git/CABn0oJvg3M_kBW-u=j3QhKnO=6QOzk-YFTgonYw_UvFS1NTX4g@mail.gmail.com/
- Resolves go-gitea#2333.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/question Issue needs no code to be fixed, only a description on how to fix it yourself.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lafriks @strk @sulliwane @bkcsoft