Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File names get truncated too aggressively on mobile version #20040

Closed
Fogapod opened this issue Jun 19, 2022 · 5 comments · Fixed by #20243
Closed

File names get truncated too aggressively on mobile version #20040

Fogapod opened this issue Jun 19, 2022 · 5 comments · Fixed by #20243
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@Fogapod
Copy link
Contributor

Fogapod commented Jun 19, 2022

Description

This is especially bad with nested directories. It looks like ui is trying to fit in commit message which isn't shown in mobile version, looks like a hard 15 character limit.

I don't actually know why github removed commit messages for mobile version, i dislike that change, gitea does the same now

Screenshots

Screenshot_20220619-162836_Brave

Gitea Version

1.18.0+dev-5-gcc42c6488

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Android

Browser Version

Chromium 102 based

@Fogapod Fogapod added type/bug topic/ui Change the appearance of the Gitea UI labels Jun 19, 2022
@zeripath
Copy link
Contributor

zeripath commented Jun 19, 2022

The issue appears to be:

&.name {
max-width: 150px;
}

I'm not sure what the purpose of this 150px is...

@Gusted
Copy link
Contributor

Gusted commented Jun 19, 2022

I'm not sure what the purpose of this 150px is...

#6867

🤷🏽 I've tried to change it to dynamic width, seems like the HTML/CSS specification allows td elements to stretch to it's content, so enforcing the width of the parent has no luck and I'd prefer to not make this table scrollable on the y-as. So max-width probably would need something like calc(...) or just a higher limit.

gitea does the same now

There's really no room at all on mobile to show a proper commit message with the new actual proper mobile design of the file view. It will look cramped and messy. Otherwise we end up with max two words or with more vertical space.

@zeripath
Copy link
Contributor

I'm not sure what the purpose of this 150px is...

#6867

🤷🏽 I've tried to change it to dynamic width, seems like the HTML/CSS specification allows td elements to stretch to it's content, so enforcing the width of the parent has no luck and I'd prefer to not make this table scrollable on the y-as. So max-width probably would need something like calc(...) or just a higher limit.

yeah calc might work better. Maybe a max-width: 33% or something like that?

gitea does the same now

There's really no room at all on mobile to show a proper commit message with the new actual proper mobile design of the file view. It will look cramped and messy. Otherwise we end up with max two words or with more vertical space.

Perhaps it needs to be an accordion like <details>

@Gusted
Copy link
Contributor

Gusted commented Jun 22, 2022

yeah calc might work better.

Yeah but it will be a nightmare solution tbh because you cannot use anything relative to the parent, because HTML/CSS specification allows td elements to stretch to it's content in theory the parent can become infinity amount of width.

Maybe a max-width: 33% or something like that?

^ So that won't work.

Perhaps it needs to be an accordion like <details>

Seems like a good idea to me.

@Fogapod
Copy link
Contributor Author

Fogapod commented Jun 26, 2022

Screenshot_20220626-102629_Brave

same thing happens when file is opened even though limit seem slightly higher there

zeripath added a commit to zeripath/gitea that referenced this issue Jul 5, 2022
Adjust the max-widths for the repository file table to allow for nicer
resizing of the names and commit messages.

Fix go-gitea#20040

Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added a commit that referenced this issue Jul 5, 2022
Adjust the max-widths for the repository file table to allow for nicer
resizing of the names and commit messages.

Fix #20040

Signed-off-by: Andrew Thornton <art27@cantab.net>

## Screenshots

## MediaXL
![Screenshot from 2022-07-05 10-22-12](https://user-images.githubusercontent.com/1824502/177295867-7ba8cf60-8f61-4227-892f-e5a0477e4146.png)

## MediaLg
![Screenshot from 2022-07-05 10-24-37](https://user-images.githubusercontent.com/1824502/177296301-e066e206-10f7-4a15-a68b-0f772a95f369.png)

## MediaMd
![Screenshot from 2022-07-05 10-23-03](https://user-images.githubusercontent.com/1824502/177295965-69397649-16ca-456a-bc0c-ed507fcb7f44.png)

## MediaSm
![Screenshot from 2022-07-05 10-26-44](https://user-images.githubusercontent.com/1824502/177296700-ca2a853b-c47b-4592-baf4-4bc08a7e1c9c.png)
zeripath added a commit to zeripath/gitea that referenced this issue Jul 5, 2022
Adjust the max-widths for the repository file table to allow for nicer
resizing of the names and commit messages.

Fix go-gitea#20040

Signed-off-by: Andrew Thornton <art27@cantab.net>

 ## Screenshots

 ## MediaXL
![Screenshot from 2022-07-05 10-22-12](https://user-images.githubusercontent.com/1824502/177295867-7ba8cf60-8f61-4227-892f-e5a0477e4146.png)

 ## MediaLg
![Screenshot from 2022-07-05 10-24-37](https://user-images.githubusercontent.com/1824502/177296301-e066e206-10f7-4a15-a68b-0f772a95f369.png)

 ## MediaMd
![Screenshot from 2022-07-05 10-23-03](https://user-images.githubusercontent.com/1824502/177295965-69397649-16ca-456a-bc0c-ed507fcb7f44.png)

 ## MediaSm
![Screenshot from 2022-07-05 10-26-44](https://user-images.githubusercontent.com/1824502/177296700-ca2a853b-c47b-4592-baf4-4bc08a7e1c9c.png)
zeripath added a commit that referenced this issue Jul 5, 2022
Backport #20243

Adjust the max-widths for the repository file table to allow for nicer
resizing of the names and commit messages.

Fix #20040

Signed-off-by: Andrew Thornton <art27@cantab.net>

 ## Screenshots

 ## MediaXL
![Screenshot from 2022-07-05 10-22-12](https://user-images.githubusercontent.com/1824502/177295867-7ba8cf60-8f61-4227-892f-e5a0477e4146.png)

 ## MediaLg
![Screenshot from 2022-07-05 10-24-37](https://user-images.githubusercontent.com/1824502/177296301-e066e206-10f7-4a15-a68b-0f772a95f369.png)

 ## MediaMd
![Screenshot from 2022-07-05 10-23-03](https://user-images.githubusercontent.com/1824502/177295965-69397649-16ca-456a-bc0c-ed507fcb7f44.png)

 ## MediaSm
![Screenshot from 2022-07-05 10-26-44](https://user-images.githubusercontent.com/1824502/177296700-ca2a853b-c47b-4592-baf4-4bc08a7e1c9c.png)

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
dineshsalunke pushed a commit to dineshsalunke/gitea that referenced this issue Jul 9, 2022
Adjust the max-widths for the repository file table to allow for nicer
resizing of the names and commit messages.

Fix go-gitea#20040

Signed-off-by: Andrew Thornton <art27@cantab.net>

## Screenshots

## MediaXL
![Screenshot from 2022-07-05 10-22-12](https://user-images.githubusercontent.com/1824502/177295867-7ba8cf60-8f61-4227-892f-e5a0477e4146.png)

## MediaLg
![Screenshot from 2022-07-05 10-24-37](https://user-images.githubusercontent.com/1824502/177296301-e066e206-10f7-4a15-a68b-0f772a95f369.png)

## MediaMd
![Screenshot from 2022-07-05 10-23-03](https://user-images.githubusercontent.com/1824502/177295965-69397649-16ca-456a-bc0c-ed507fcb7f44.png)

## MediaSm
![Screenshot from 2022-07-05 10-26-44](https://user-images.githubusercontent.com/1824502/177296700-ca2a853b-c47b-4592-baf4-4bc08a7e1c9c.png)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this issue Aug 10, 2022
Adjust the max-widths for the repository file table to allow for nicer
resizing of the names and commit messages.

Fix go-gitea#20040

Signed-off-by: Andrew Thornton <art27@cantab.net>

## Screenshots

## MediaXL
![Screenshot from 2022-07-05 10-22-12](https://user-images.githubusercontent.com/1824502/177295867-7ba8cf60-8f61-4227-892f-e5a0477e4146.png)

## MediaLg
![Screenshot from 2022-07-05 10-24-37](https://user-images.githubusercontent.com/1824502/177296301-e066e206-10f7-4a15-a68b-0f772a95f369.png)

## MediaMd
![Screenshot from 2022-07-05 10-23-03](https://user-images.githubusercontent.com/1824502/177295965-69397649-16ca-456a-bc0c-ed507fcb7f44.png)

## MediaSm
![Screenshot from 2022-07-05 10-26-44](https://user-images.githubusercontent.com/1824502/177296700-ca2a853b-c47b-4592-baf4-4bc08a7e1c9c.png)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants