Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue search API with created param returns 500 if not logged in #19115

Closed
qwerty287 opened this issue Mar 17, 2022 · 0 comments · Fixed by #19154
Closed

Issue search API with created param returns 500 if not logged in #19115

qwerty287 opened this issue Mar 17, 2022 · 0 comments · Fixed by #19154
Labels
type/bug
Milestone
1.16.5

Comments

@qwerty287
Copy link
Contributor

Gitea Version

v1.16

Git Version

No response

Operating System

No response

How are you running Gitea?

Codeberg.org

Database

No response

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Description

The issues search api (/repos/issues/search) returns 500 server error if you are requesting it without token/not logged in and including the created=true query param. It should return an empty list.

Screenshots

No response
@lunny lunny added the type/bug label Mar 18, 2022
@lunny lunny added this to the 1.16.5 milestone Mar 18, 2022
Gusted pushed a commit to Gusted/gitea that referenced this issue Mar 20, 2022
Fix NPE /repos/issues/search when not signed in
bdf4c61 
- Don't panic when on
`/repos/issues/search?{created,assigned,mentioned,review_requested}=true`
when client didn't pass any authentication.
- Resolves go-gitea#19115
@Gusted Gusted mentioned this issue Mar 20, 2022
Merged
Gusted pushed a commit to Gusted/gitea that referenced this issue Mar 20, 2022
Fix NPE /repos/issues/search when not signed in (go-gitea#19154)
034839e 
- Backport go-gitea#19154

  - Don't panic when on `/repos/issues/search?{created,assigned,mentioned,review_requested}=true` when client didn't pass any authentication.
  - Resolves go-gitea#19115
@Gusted Gusted mentioned this issue Mar 20, 2022
Merged
6543 pushed a commit that referenced this issue Mar 20, 2022
Fix NPE /repos/issues/search when not signed in (#19154)
49c5fc5 
- Don't panic when on
`/repos/issues/search?{created,assigned,mentioned,review_requested}=true`
when client didn't pass any authentication.
- Resolves #19115
6543 pushed a commit that referenced this issue Mar 20, 2022
Fix NPE /repos/issues/search when not signed in (#19154) (#19155)
ee234af 
- Backport #19154

  - Don't panic when on `/repos/issues/search?{created,assigned,mentioned,review_requested}=true` when client didn't pass any authentication.
  - Resolves #19115
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
Fix NPE /repos/issues/search when not signed in (go-gitea#19154)
07007d6 
- Don't panic when on
`/repos/issues/search?{created,assigned,mentioned,review_requested}=true`
when client didn't pass any authentication.
- Resolves go-gitea#19115
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.16.5
Development

Successfully merging a pull request may close this issue.

Fix NPE /repos/issues/search when not signed in Gusted/gitea
2 participants
@lunny @qwerty287