Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo Search May Not Show Results Immediately #15425

Closed
2 of 6 tasks
muellert opened this issue Apr 12, 2021 · 2 comments · Fixed by #15428
Closed
2 of 6 tasks

Repo Search May Not Show Results Immediately #15425

muellert opened this issue Apr 12, 2021 · 2 comments · Fixed by #15428
Labels
Milestone

Comments

@muellert
Copy link

Description

If I am on the dashboard and search a repo, matching repos are being displayed if I start the search from the first page. If I start the search from a page "after" the page which lists this repo in the absence of a search operation, there is only a number being displayed in one of the repo categories, but a matching repo is not being displayed unless one clicks the category button with the number. After that, the repo link appears in the result box and can be clicked to navigate to that repo.

Screenshots

20210412-gitea-search-box-problem

@zeripath
Copy link
Contributor

The title of this issue is rather confusing. The issue here is that the search term has been changed but the current page number is greater than the maximum number of results for that new search term.

I guess the correct behaviour is that changing the search term should reset the page number to 1, as it makes no sense to keep the current page.

@muellert
Copy link
Author

I didn't think of it that way, but your argument sounds very plausible.

@6543 6543 added this to the 1.14.1 milestone Apr 12, 2021
zeripath added a commit to zeripath/gitea that referenced this issue Apr 12, 2021
When inputing the search term on the repolist on the user home page the component
page should be reset to page 1.

Fix go-gitea#15425

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
4 participants