Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No email notifications are sent for PR's if issues repo unit is disabled #14250

Closed
jpraet opened this issue Jan 5, 2021 · 2 comments · Fixed by #14252
Closed

No email notifications are sent for PR's if issues repo unit is disabled #14250

jpraet opened this issue Jan 5, 2021 · 2 comments · Fixed by #14252
Labels
type/bug
Milestone
1.13.2

Comments

@jpraet
Copy link
Member

jpraet commented Jan 5, 2021

  • Gitea version (or commit ref): 1.13.1

Description

After upgrading to 1.13.1, no email notifications are sent for PR's if Issues are disabled for the repo.

This is caused by #13827: it should check for UnitTypePullRequests instead of UnitTypeIssues permission if it concerns a PR.
a1012112796 added a commit to a1012112796/gitea that referenced this issue Jan 5, 2021
@a1012112796
fix mailIssueCommentBatch for pull request
d2e77ad 
fix go-gitea#14250

Signed-off-by: a1012112796 <1012112796@qq.com>
@a1012112796 a1012112796 mentioned this issue Jan 5, 2021
Merged
@lunny lunny added this to the 1.13.2 milestone Jan 5, 2021
zeripath pushed a commit that referenced this issue Jan 9, 2021
@a1012112796
fix mailIssueCommentBatch for pull request (#14252)
d989247 
fix #14250

Signed-off-by: a1012112796 <1012112796@qq.com>
a1012112796 added a commit to a1012112796/gitea that referenced this issue Jan 10, 2021
@a1012112796
fix mailIssueCommentBatch for pull request (go-gitea#14252)
77a2bae 
fix go-gitea#14250

Signed-off-by: a1012112796 <1012112796@qq.com>
lunny pushed a commit that referenced this issue Jan 11, 2021
@a1012112796
fix mailIssueCommentBatch for pull request (#14252) (#14296)
bf853db 
fix #14250

Signed-off-by: a1012112796 <1012112796@qq.com>
@jpraet
Copy link
Member Author

jpraet commented Jan 25, 2021

Any idea when 1.13.2 will be released?

@lunny
Copy link
Member

lunny commented Jan 26, 2021

Only one issue left on v1.13.2.

@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.13.2
Development

Successfully merging a pull request may close this issue.

fix mailIssueCommentBatch for pull request a1012112796/gitea
3 participants
@lunny @jpraet @a1012112796