Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Only Email on Mention" settings is broken #12774

Closed
2 of 7 tasks
ashimokawa opened this issue Sep 9, 2020 · 3 comments · Fixed by #12775
Closed
2 of 7 tasks

"Only Email on Mention" settings is broken #12774

ashimokawa opened this issue Sep 9, 2020 · 3 comments · Fixed by #12775
Labels
type/bug

Comments

@ashimokawa
Copy link
Contributor

ashimokawa commented Sep 9, 2020 •
edited
Loading

  • Gitea version (or commit ref): 1.12.4
  • Git version: 2.20.1
  • Operating system: Debian 10
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

When going to your account settings and choosing the “Only Email on Mention” settings, the will be no Emails sent at all, even if mentioned

We tried this on try.gitea.io and had the same problem. EMails are send out if you choose the standard setting to get notified always. And in that case the Emails also says that you have been mentioned.

https://codeberg.org/Codeberg/Community/issues/257
@lunny
Copy link
Member

lunny commented Sep 9, 2020

We need a new mock mail sender for tests.

@a1012112796
Copy link
Member

ref #7813

a1012112796 added a commit to a1012112796/gitea that referenced this issue Sep 9, 2020
@a1012112796
fix mail mention bug
ae47763 
fix go-gitea#12774

Signed-off-by: a1012112796 <1012112796@qq.com>
@a1012112796 a1012112796 mentioned this issue Sep 9, 2020
Merged
@6543 6543 added the type/bug label Sep 9, 2020
techknowlogick added a commit that referenced this issue Sep 9, 2020
@a1012112796 @techknowlogick
Fix "only mail on mention" bug (#12775)
ffa12bd 
* fix mail mention bug

fix #12774

Signed-off-by: a1012112796 <1012112796@qq.com>

* fix test

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
a1012112796 added a commit to a1012112796/gitea that referenced this issue Sep 10, 2020
@a1012112796 @techknowlogick
Fix "only mail on mention" bug (go-gitea#12775)
c27cc1a 
* fix mail mention bug

fix go-gitea#12774

Signed-off-by: a1012112796 <1012112796@qq.com>

* fix test

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
lafriks pushed a commit that referenced this issue Sep 10, 2020
@a1012112796 @techknowlogick
Fix "only mail on mention" bug (#12775) (#12789)
0ee823b 
* fix mail mention bug

fix #12774

Signed-off-by: a1012112796 <1012112796@qq.com>

* fix test

Co-authored-by: techknowlogick <techknowlogick@gitea.io>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@strangezakary
Copy link

Hi guys, I'm getting this exact issue in 1.13 RC1 as well. I think this patch would be in 1.13, but maybe I'm missing something, or maybe this is a new bug.

Thanks in advance,

@strangezakary strangezakary mentioned this issue Nov 6, 2020
Closed
4 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix "only mail on mention" bug a1012112796/gitea
5 participants
@lunny @ashimokawa @strangezakary @6543 @a1012112796