Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move eventsource.sharedworker to worker-loader #12459

Open
silverwind opened this issue Aug 8, 2020 · 2 comments
Open

Move eventsource.sharedworker to worker-loader #12459

silverwind opened this issue Aug 8, 2020 · 2 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@silverwind
Copy link
Member

worker-loader@3.0.0 has been released so we can now update it and move the shared worker to load with it using the workerType option. cc: @zeripath.
@silverwind silverwind mentioned this issue Aug 11, 2020
Merged
silverwind added a commit to silverwind/gitea that referenced this issue Aug 11, 2020
@silverwind
Update JS dependencies
7b5de89 
- Update worker-loader options (currently unused pending go-gitea#12459)
- Remove @babel/plugin-proposal-object-rest-spread, it's enabled by
  default
- Switch cssnano-webpack-plugin to css-minimizer-webpack-plugin which
  had been renamed
sapk pushed a commit that referenced this issue Aug 11, 2020
@silverwind
Update JS dependencies (#12474)
c18b052 
* Update JS dependencies

- Update worker-loader options (currently unused pending #12459)
- Remove @babel/plugin-proposal-object-rest-spread, it's enabled by
  default
- Switch cssnano-webpack-plugin to css-minimizer-webpack-plugin which
  had been renamed

* switch to css-minimizer-webpack-plugin
@zeripath zeripath mentioned this issue Aug 20, 2020
Closed
@stale
Copy link

stale bot commented Oct 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Oct 11, 2020
@lunny lunny added type/proposal The new feature has not been accepted yet but needs to be discussed first. issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented labels Oct 12, 2020
@stale stale bot removed the issue/stale label Oct 12, 2020
@silverwind
Copy link
Member Author

silverwind commented Oct 30, 2020 •
edited
Loading

I think this depends on webpack 5 if we want it in an async chunk. Still some blockers for webpack 5 thought.

@silverwind silverwind mentioned this issue Dec 27, 2020
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lunny @silverwind