Fix bug on user setting (#22539)

Fix #22537 Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
go-gitea · Jan 21, 2023 · eb793c3 · eb793c3
1 parent a1fcb1c
commit eb793c3
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/models/user/setting.go b/models/user/setting.go
@@ -10,6 +10,7 @@ import (
 
 	"code.gitea.io/gitea/models/db"
 	"code.gitea.io/gitea/modules/cache"
+	setting_module "code.gitea.io/gitea/modules/setting"
 
 	"xorm.io/builder"
 )
@@ -154,11 +155,16 @@ func SetUserSetting(userID int64, key, value string) error {
 		return err
 	}
 
-	_, err := cache.GetString(genSettingCacheKey(userID, key), func() (string, error) {
-		return value, upsertUserSettingValue(userID, key, value)
-	})
+	if err := upsertUserSettingValue(userID, key, value); err != nil {
+		return err
+	}
 
-	return err
+	cc := cache.GetCache()
+	if cc != nil {
+		return cc.Put(genSettingCacheKey(userID, key), value, setting_module.CacheService.TTLSeconds())
+	}
+
+	return nil
 }
 
 func upsertUserSettingValue(userID int64, key, value string) error {