Skip to content

Commit

Permalink
Improve the comment for 2FA filter in admin panel (#18017)
Browse files Browse the repository at this point in the history
Replace TODO with explanation

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
  • Loading branch information
Gusted and wxiaoguang authored Jan 13, 2022
1 parent 696521b commit d413a1f
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion models/user/search.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,9 @@ func (opts *SearchUserOptions) toSearchQueryBase() *xorm.Session {
}

// 2fa filter uses LEFT JOIN to check whether a user has a 2fa record
// TODO: bad performance here, maybe there will be a column "is_2fa_enabled" in the future
// While using LEFT JOIN, sometimes the performance might not be good, but it won't be a problem now, such SQL is seldom executed.
// There are some possible methods to refactor this SQL in future when we really need to optimize the performance (but not now):
// (1) add a column in user table (2) add a setting value in user_setting table (3) use search engines (bleve/elasticsearch)
if opts.IsTwoFactorEnabled.IsTrue() {
cond = cond.And(builder.Expr("two_factor.uid IS NOT NULL"))
} else {
Expand Down

0 comments on commit d413a1f

Please sign in to comment.