-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Include OriginalAuthor in Reaction constraint (#13505)
When migrating repositories with reactions with deleted users, the original author id may be -1. This means that it is possible to end up attempting to create multiple reactions with the same [ Type, IssueID, CommentID, UserID, OriginalAuthorID ] thus breaking the constraints. On SQLite this appears to cause a deadlock but on other dbs this will cause the migration to fail. This PR extends the constraint to include the original author username in the constraint. Fix #13271 Signed-off-by: Andrew Thornton <art27@cantab.net>
- Loading branch information
Showing
3 changed files
with
47 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
// Copyright 2020 The Gitea Authors. All rights reserved. | ||
// Use of this source code is governed by a MIT-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package migrations | ||
|
||
import ( | ||
"code.gitea.io/gitea/modules/timeutil" | ||
|
||
"xorm.io/xorm" | ||
) | ||
|
||
func updateReactionConstraint(x *xorm.Engine) error { | ||
// Reaction represents a reactions on issues and comments. | ||
type Reaction struct { | ||
ID int64 `xorm:"pk autoincr"` | ||
Type string `xorm:"INDEX UNIQUE(s) NOT NULL"` | ||
IssueID int64 `xorm:"INDEX UNIQUE(s) NOT NULL"` | ||
CommentID int64 `xorm:"INDEX UNIQUE(s)"` | ||
UserID int64 `xorm:"INDEX UNIQUE(s) NOT NULL"` | ||
OriginalAuthorID int64 `xorm:"INDEX UNIQUE(s) NOT NULL DEFAULT(0)"` | ||
OriginalAuthor string `xorm:"INDEX UNIQUE(s)"` | ||
CreatedUnix timeutil.TimeStamp `xorm:"INDEX created"` | ||
} | ||
|
||
sess := x.NewSession() | ||
defer sess.Close() | ||
|
||
if err := sess.Begin(); err != nil { | ||
return err | ||
} | ||
|
||
if err := recreateTable(sess, &Reaction{}); err != nil { | ||
return err | ||
} | ||
|
||
return sess.Commit() | ||
} |