This repository has been archived by the owner on Apr 12, 2019. It is now read-only.
Revert to old implementation of GetCommitsInfo #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have idea how to fix it in #71 I will do this later when I'm home. If it will not work out than revert |
|
@ethantkoenig please check #71 with changed code |
|
Ok, closed my PR. For now it looks like revert is best option right now so LGTM |
|
LGTM |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #53 (and several subsequent bug fixes).
There are problems with the new implementation of
GetCommitsInfo(..)that was introduced in #53 (see #72). For the sake of having a bug-free 1.2.0 release, we should revert to the old, slower implementation for now.I do still hope to eventually salvage the faster implementation.