Close via defer #47
Merged
Close via defer #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If write were to panic, the file would not get closed. Adding a defer and checking if 'f' is nil prior to closing ensures we will always close the file and only once.
pjbgf
reviewed
Mar 26, 2024
pjbgf
reviewed
Mar 26, 2024
spennymac
force-pushed
the
close-via-defer
branch
from
012ec73
to
c98c36d
Compare
spennymac
commented
Mar 26, 2024
pjbgf
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If write were to panic, the file would not get closed. Adding a defer and checking if 'f' is nil prior to closing ensures we will always closethe file and only once.