Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve BCE in CH128 computing #3

Merged
merged 3 commits into from
Jan 25, 2022

Conversation

tdakkota
Copy link
Member

Benchstat result

name                   old speed      new speed      delta
ClickHouse128/16-12    1.76GB/s ± 0%  1.77GB/s ± 1%  +0.32%  (p=0.021 n=14+15)
ClickHouse128/64-12    4.06GB/s ± 1%  4.38GB/s ± 0%  +7.94%  (p=0.000 n=14+13)
ClickHouse128/256-12   5.58GB/s ± 0%  5.74GB/s ± 0%  +2.72%  (p=0.000 n=14+14)
ClickHouse128/1024-12  7.61GB/s ± 0%  8.03GB/s ± 2%  +5.56%  (p=0.000 n=12+15)

go-perftuner boundChecks result diff

@@ -1,13 +1,3 @@
-./ch_128.go:35:9: slice/array has bound checks
-./ch_128.go:126:40: slice/array has bound checks
-./ch_128.go:129:28: slice/array has bound checks
-./ch_128.go:29:44: slice/array has bound checks
-./ch_128.go:32:44: slice/array has bound checks
-./ch_128.go:83:59: slice/array has bound checks
-./ch_128.go:85:45: slice/array has bound checks
-./ch_128.go:91:50: slice/array has bound checks
-./ch_128.go:92:49: slice/array has bound checks
-./ch_128.go:106:50: slice/array has bound checks
-./ch_128.go:107:49: slice/array has bound checks
-./ch_128.go:126:38: slice/array has bound checks
-./ch_128.go:53:36: slice/array has bound checks
+./ch_128.go:142:40: slice/array has bound checks
+./ch_128.go:145:28: slice/array has bound checks
+./ch_128.go:142:38: slice/array has bound checks

@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #3 (6c6a5e4) into main (7195a37) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          603       615   +12     
=========================================
+ Hits           603       615   +12     
Impacted Files Coverage Δ
ch_128.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7195a37...6c6a5e4. Read the comment docs.

@ernado ernado merged commit a8bba0b into go-faster:main Jan 25, 2022
@tdakkota tdakkota deleted the feat/optimize branch January 25, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants