pkg/proc: be resilient to the upcoming sys.PtraceLwpInfo changes #3284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of golang/go#58387 work (CL 469835), the signature of sys.PtraceLwpInfo will change to accept *sys.PtraceLwpInfoStruct instead of an uintptr. As a compatibility measure, update ptraceGetLwpInfo to work with both old and new sys.PtraceLwpInfo signatures.
|
I don't think this is necessary. Delve links to a specific version of x/sys and it only needs to support that: when we update x/sys we will change that function. I don't want to update it now because it will bump up the minimum version of Go that can build Delve by a lot of versions. |
|
That makes sense, please feel free to close this PR. |
|
Closing. Thank you anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of golang/go#58387 work (CL 469835), the signature of sys.PtraceLwpInfo will change to accept *sys.PtraceLwpInfoStruct instead of an uintptr. As a compatibility measure, update ptraceGetLwpInfo to work with both old and new sys.PtraceLwpInfo signatures.