Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/dap: handle no-such-process disconnect error #2476

Merged
merged 3 commits into from
Jun 10, 2021
Merged

service/dap: handle no-such-process disconnect error #2476

merged 3 commits into from
Jun 10, 2021

Conversation

polinasok
Copy link
Collaborator

No description provided.

@polinasok polinasok mentioned this pull request May 11, 2021
Merged
@aarzilli
Copy link
Member

I was thinking about this during the weekend and I think I know what's going on with that test. I want to take a deeper look at it, probably later this week or during the weekend.

@polinasok polinasok mentioned this pull request May 12, 2021
Merged
@polinasok
Copy link
Collaborator Author

I was thinking about this during the weekend and I think I know what's going on with that test. I want to take a deeper look at it, probably later this week or during the weekend.

I am intrigued. Looking forward to the mystery reveal :)

@polinasok
Copy link
Collaborator Author

I will update this PR once #2477 is in.

@derekparker
Copy link
Member

@polinasok #2477 has been merged.

@derekparker derekparker added this to the 1.6.2 milestone May 19, 2021
@polinasok polinasok changed the title service/dap: handle no-such-process disconnect error and fix flaky test service/dap: handle no-such-process disconnect error Jun 9, 2021
@polinasok
Copy link
Collaborator Author

TestAttachStopOnEntry is no longer flaky, so I have dropped the changes in the test.
Keeping the no-such-process handling changes. Except I am no longer sure how to trigger such a case in the tests.

derekparker
derekparker approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker derekparker merged commit fb4d6f1 into go-delve:master Jun 10, 2021
OneOfOne added a commit to OneOfOne/delve that referenced this pull request Jun 10, 2021
@OneOfOne
Merge branch 'master' of https://github.com/go-delve/delve
96e693e 
* 'master' of https://github.com/go-delve/delve:
  service/dap: implement array, slice, and map paging (go-delve#2512)
  service/dap: handle no-such-process error on disconnect and fix flaky test (go-delve#2476)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekparker derekparker derekparker approved these changes

@aarzilli aarzilli aarzilli approved these changes

Assignees
No one assigned
Labels
area/dap priority/P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@polinasok @aarzilli @derekparker