service/dap: Add support for debug and test modes #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarzilli
reviewed
Mar 1, 2020
pkg/gobuild/gobuild.go
Outdated
| } | ||
|
|
||
| // OptFlags generates default build flags to turn off optimization and inlining. | ||
| func OptFlags(args []string) []string { |
There was a problem hiding this comment.
As far as I can tell this is only called inside gobuild, it doesn't need to be exported.
There was a problem hiding this comment.
Good point. Fixed.
derekparker
requested changes
Mar 3, 2020
derekparker
approved these changes
Mar 4, 2020
cgxxv
pushed a commit
to cgxxv/delve
that referenced
this pull request
Mar 25, 2022
* service/dap: Add support for debug and test modes * Address code review comments * Remove //dap comment * OptFlags() => optfalgs() * If mode => switch mode
abner-chenc
pushed a commit
to loongson/delve
that referenced
this pull request
Mar 1, 2024
* service/dap: Add support for debug and test modes * Address code review comments * Remove //dap comment * OptFlags() => optfalgs() * If mode => switch mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also:
-- refactors building helper functions from commands.go into its own gobuild package.
-- makes processing untyped launch args (that are implementation-specific and not part of the DAP spec) more robust, verified by additional tests
Updates #1515