Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-756: fix interface variadic parameters verifying #757

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

apocelipes
Copy link
Contributor

@apocelipes apocelipes commented Jul 17, 2024

Fixes #756.

What does this do?

Check interface-implements if variadic parameter's types is an interface.

Which issue(s) does this PR fix/relate to?

Resolves #756

List any changes that modify/break current functionality

Nothing.

Have you included tests for your changes?

Yes. I have added 2 test cases.

Did you document any new/modified functionality?

  • Updated scheduler_test.go

Notes

@apocelipes apocelipes changed the title Fix interface variadic parameters verifying issue-756: fix interface variadic parameters verifying Jul 17, 2024
scheduler_test.go Outdated Show resolved Hide resolved
@JohnRoesler JohnRoesler merged commit f37e274 into go-co-op:v2 Jul 17, 2024
4 checks passed
@apocelipes apocelipes deleted the fix-756 branch July 17, 2024 12:31
rbroggi pushed a commit to rbroggi/gocron that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - cannot handle variadic interface parameters
2 participants