allow max concurrent runs and singleton mode together #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnRoesler
force-pushed
the
limitmodesingleton
branch
from
3a40262 to
df8e13d
Compare
JohnRoesler
commented
Nov 28, 2023
| _, ok := e.limitMode.singletonJobs[id] | ||
| if ok { | ||
| // this job is already running, so don't run it | ||
| // but instead reschedule it |
There was a problem hiding this comment.
Effectively, singleton mode is always reschedule with max concurrent. Is there a need to allow for singleton jobs to wait? It seems like no
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
allows for singleton mode and max concurrent runs to be combined. The resulting behavior is that if you have a limit of say 2 jobs concurrently, you can't have one job take both those slots. By having singleton enabled on a job, it is prevented from running by two limitModeRunners simultaneously.
Which issue(s) does this PR fix/relate to?
#624
List any changes that modify/break current functionality
Have you included tests for your changes?
Did you document any new/modified functionality?
example_test.goREADME.mdNotes