Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: follow Go convention about generated comment #2292

Merged
merged 2 commits into from
Oct 5, 2024
Merged

fix: follow Go convention about generated comment #2292

merged 2 commits into from
Oct 5, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Oct 4, 2024

@ldez ldez requested a review from dmke October 4, 2024 22:51
dmke
dmke requested changes Oct 5, 2024
View reviewed changes
Copy link
Member

@dmke dmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hang on,

This line must appear before the first non-comment, non-blank text in the file.

i.e. before the package statement.

@ldez ldez requested a review from dmke October 5, 2024 12:10
@ldez ldez merged commit 36fa8b6 into go-acme:master Oct 5, 2024
4 checks passed
@ldez ldez deleted the fix/follow-convention branch October 5, 2024 13:13
@ldez ldez added this to the v4.19 milestone Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmke dmke dmke approved these changes

Assignees
No one assigned
Labels
area/dnsprovider area/infrastructure
Milestone
v4.19
Development

Successfully merging this pull request may close these issues.
2 participants
@ldez @dmke