Add AlwaysDeactivateAuthorizations flag to ObtainRequest #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinWeindel
force-pushed
the
v4.4-branch
branch
from
2414820 to
4c5884e
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a successful certificate request, the authorizations may be cached by the ACME provider for some time.
For example Let's encrypt caches them for 30 days
If the registration account is shared between multiple clients, a client can request a new certificate for domains already requested by the original client without new validation.
To avoid this behaviour, the authorizations must be deactivated explicitly, see RFC 8555, Deactivating an Authorization
With this PR, a flag
AlwaysDeactivateAuthorizationsis introduced to theObtainRequestandObtainForCSRRequestto enable this deactivation after a successful certificate request optionally. The default behaviour is kept unchanged.