Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix backoff in SolverManager #1428

Merged
merged 2 commits into from
Jun 11, 2021
Merged

lib: fix backoff in SolverManager #1428

merged 2 commits into from
Jun 11, 2021

Conversation

quenbyako
Copy link
Contributor

@quenbyako quenbyako commented Jun 11, 2021 •
edited by ldez
Loading

well, fix this strange bug, described at #1427 ¯\_(ツ)_/¯

idk what to say else... hooray, opensource! 🎉🥳

Fixes #1427

@ldez ldez changed the title backoff error fix (#1427) backoff error fix Jun 11, 2021
@ldez ldez changed the title backoff error fix lib: fix backoff in SolverManager Jun 11, 2021
ldez
ldez approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend using a more formal tone (avoid "fuck", "lol", "hell", "shrug", etc.), I'm not your friend.

Even if your issue is not reproducible, the change is right, then I will merge the PR.

@ldez ldez merged commit 9b44e4a into go-acme:master Jun 11, 2021
@ldez ldez added this to the v4.4 milestone Jun 11, 2021
@ldez ldez mentioned this pull request Jun 11, 2021
Merged
@quenbyako quenbyako deleted the backoff-fix branch June 11, 2021 03:48
@quenbyako
Copy link
Contributor Author

quenbyako commented Jun 11, 2021 •
edited
Loading

Thanks a lot for fast fix! Really appreciate that!

image

@ldez ldez modified the milestones: v4.4, v4.5 Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/lib bug
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

Resolver doesn't say properly real error when ussing backoff
2 participants
@quenbyako @ldez