Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nifcloud: Get zone info from dns01.FindZoneByFqdn #1383

Merged

Conversation

kakakikikeke-fork
Copy link
Contributor

@kakakikikeke-fork kakakikikeke-fork commented Apr 8, 2021

I updated dns nifcloud provider. There was an error in the method of specifying the Zone, so I fixed it.

Fixes #1382

@kakakikikeke-fork kakakikikeke-fork changed the title nifcloud: Get zone info from dns01.FindZoneByFqdn WIP: nifcloud: Get zone info from dns01.FindZoneByFqdn Apr 8, 2021
@kakakikikeke-fork kakakikikeke-fork changed the title WIP: nifcloud: Get zone info from dns01.FindZoneByFqdn nifcloud: Get zone info from dns01.FindZoneByFqdn Apr 8, 2021
@ldez ldez self-requested a review April 8, 2021 07:04
@ldez ldez added this to the v4.4 milestone Apr 8, 2021
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ldez ldez merged commit 2334340 into go-acme:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

nifcloud: You can only get a certificate with a common name that has the same name as the hostedZone.
2 participants