Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --preferred-chain option to support "alternate" certificate links #1227

Merged
merged 11 commits into from
Sep 2, 2020

Conversation

Songmu
Copy link
Contributor

@Songmu Songmu commented Aug 9, 2020

resolve #1197

I implemented it referenced from the following pull request of certbot.

certbot/certbot#8080

This change is needed asap, because Let's Encrypt is to change its default certificate chain on September 29.

ref.

@ldez ldez modified the milestones: v3.9, v4.0 Aug 26, 2020
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ldez ldez merged commit 30e4987 into go-acme:master Sep 2, 2020
@Songmu Songmu deleted the prefered-chain branch September 2, 2020 00:55
@Songmu
Copy link
Contributor Author

Songmu commented Sep 2, 2020

Sorry for sending an incomplete pull request. I hadn't gotten around to fixing it, but thank you for completing it on your end. @ldez

@ldez ldez added the breaking-change Require or introduce a breaking change. label Sep 2, 2020
@FStelzer
Copy link

FStelzer commented Sep 2, 2020

Thanks a lot for implementing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli area/lib breaking-change Require or introduce a breaking change. enhancement
Development

Successfully merging this pull request may close these issues.

Support "alternate" certificate links for selecting different signing Chains
4 participants