-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Legacy ABI Compatibility #298
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn’t there more to be deleted from the upgrade logic?
Yeah but I was not sure how much to delete. Do we want to leave the gsv1 upgrade logic in place or remove it as well? |
And this would fall under |
I'm not sure. We currently don't support the new ABI on Mach-O in clang and it's quite useful to be able to run tests on macOS so that we can compare their behaviour against the Apple runtime. I've not tried WebAssembly, but it probably also needs some custom work. The main reason I'd drop the GCC ABI is that anyone using GCC should probably use their runtime. Ideally we'd get every target supported by the v1 GNUstep ABI onto v2 and then drop v1 as well. |
I did not know that we support v1 on Macho-O. It would be very interesting to support v2 as well just for benchmarking purposes. |
I'll remove the GCC upgrade logic then. |
Google recently updated the clang prebuilds for the Android SDK. The fast path test now executes and fails instead of being skipped. |
We are carrying a lot of dead-weight just by supporting the old GCC ABI which probably no one uses in combination with libobjc2.
There are still lot more ugly hacks which can be removed.