Skip to content

Commit

Permalink
MinGW: Remove manual setting of library prefix/suffix (#277)
Browse files Browse the repository at this point in the history
We no longer need to manually set these suffixes/prefixes as CMake in MSYS2 now knows about Objective C.

See msys2/MINGW-packages#20028
See https://gitlab.kitware.com/cmake/cmake/-/merge_requests/9244
See msys2/MINGW-packages#20024 (comment)
  • Loading branch information
qmfrederik committed Feb 13, 2024
1 parent e882423 commit f983cdb
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@ endif()
enable_language(OBJC OBJCXX)

if (MINGW)
set(CMAKE_IMPORT_LIBRARY_SUFFIX ".dll.a")
set(CMAKE_LINK_LIBRARY_SUFFIX "")
set(CMAKE_SHARED_LIBRARY_PREFIX "lib")
# Make sure ObjC++ source code uses the C++ implicit include directories. This is needed, for example, to make sure we use the right
# C++ headers when using clang but linking with libstdc++.
set(CMAKE_OBJCXX_IMPLICIT_INCLUDE_DIRECTORIES ${CMAKE_CXX_IMPLICIT_INCLUDE_DIRECTORIES})
endif ()

Expand Down

0 comments on commit f983cdb

Please sign in to comment.