Rework to the wrapped token approach #9
Conversation
|
|
||
| address sender = _msgSender(); | ||
|
|
||
| IERC20(_token).safeTransferFrom(sender, address(this), _amount); |
There was a problem hiding this comment.
Consider either to make the code safer by adding a check that the swap contract balance increased by expected amount of tokens or to extend the code with a comment that this check is not here because the contract admin must be sure that such tokens are not added for swap.
There was a problem hiding this comment.
Sure, added a comment
contracts/SBCWrapper.sol
Outdated
| address _token, | ||
| uint256 _amount | ||
| ) internal { | ||
| uint256 received = (_amount * tokenRate[_token]) / 1 ether; |
There was a problem hiding this comment.
Consider to make another name for the variable since although it reflects amount of tokens to receive instead of accepted tokens, it is not received yet. May it be acquired?
There was a problem hiding this comment.
Yes, sounds like a good naming to me. Thanks.
| * @param _to address that will receive the locked tokens on this contract. | ||
| */ | ||
| function claimTokens(address _token, address _to) external onlyAdmin { | ||
| require(tokenStatus[_token] == TokenStatus.DISABLED, "SBCWrapper: token already swappable"); |
There was a problem hiding this comment.
Consider to add a comment that the admin needs to make sure that the claimable token does not have the same storage with a token configured for the swap (the situation when different tokens addresses refers to the same storage contract).
The usage flow will be the following:
STAKEtokens to theSBCWrappercontractSBCWrapperto swap his tokens on the newly mintedSBCTokentokensSBCTokentokens to theSBCDepositContractcontractdepositfunction to make a final SBC deposit.Steps 1 & 2 can be completed in the same transaction by using permit function or ERC677
transferAndCallstandard in the STAKE token.Steps 3 & 4 can be completed in the same transaction via the ERC677
transferAndCallfunction in the wrapped token contract.So, in general, 2 transactions from user will be required.
Design considerations:
enableTokenfunction.