Batch deposit helper script #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k1rill-fedoseev
force-pushed
the
batch-deposit-script
branch
from
1f43cf7
to
2812065
Compare
k1rill-fedoseev
force-pushed
the
batch-deposit-script
branch
from
2812065
to
57a6b53
Compare
akolotov
suggested changes
Oct 26, 2021
scripts/.env.example
Outdated
| @@ -0,0 +1,15 @@ | |||
| DEPLOYMENT_ACCOUNT_PRIVATE_KEY=0000000000000000000000000000000000000000000000000000000000000000 | |||
There was a problem hiding this comment.
So, it is not a deployment account but the account owning stake tokens, isn't it? Consider to change the parameter to "STAKING_ACCOUNT_PRIVATE_KEY"
scripts/.env.example
Outdated
|
|
||
| RPC_URL=https://dai.poa.network | ||
|
|
||
| # number of deposits in one transaction |
There was a problem hiding this comment.
Let's make it clear - the number cannot exceed 128.
| return | ||
| } | ||
|
|
||
| if (!deposits.every(d => d.amount === 32000000000)) { |
There was a problem hiding this comment.
Does it make sense to check that the staking account owns the corresponding amount of tokens?
scripts/deposit.js
Outdated
| if (count === batchSize || i === deposits.length - 1) { | ||
| const amount = web3.utils.toBN(32 * count).mul(web3.utils.toBN('1000000000000000000')) | ||
| const call = token.methods.transferAndCall(DEPOSIT_CONTRACT_ADDRESS, amount, data) | ||
| const gas = await call.estimateGas({ from: address }) |
There was a problem hiding this comment.
Does it make sense to check in advance that the staking account has enough funds to make deposit transactions?
akolotov
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.