Stability #5
Merged
Stability #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kongzii
commented
Aug 2, 2024
| market = OmenSubgraphHandler().get_omen_market_by_market_id(market_id) | ||
| except ValueError: | ||
| raise fastapi.HTTPException( | ||
| status_code=404, detail=f"Market with id `{market_id}` not found." |
There was a problem hiding this comment.
Fastapi will handle 404 error correctly, instead of breaking the whole pod
| try: | ||
| insights = tavily_insights(market.question_title) | ||
| except Exception as e: | ||
| logger.error(f"Failed to get insights for market `{market_id}`: {e}") |
There was a problem hiding this comment.
If there is some problem with Tavily, trigger alert for us, but return empty results for them, to not break frontend.
| fastapi.Query( | ||
| ..., | ||
| description="Hex address of the market on Omen.", | ||
| pattern="^0x[a-fA-F0-9]{40}$", |
There was a problem hiding this comment.
Some basic validation of market's id, to not accept arbitrary strings.
evangriffiths
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.