Skip to content
This repository has been archived by the owner on Feb 18, 2020. It is now read-only.

Create CONTRIBUTING.md #423

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Create CONTRIBUTING.md #423

wants to merge 2 commits into from

Conversation

Velenir
Copy link
Contributor

@Velenir Velenir commented Nov 8, 2018

Contributing guide for dx-react

@ghost
Copy link

ghost commented Nov 8, 2018

Travis automatic deployment:
https://pr423--dxreact.review.gnosisdev.com

1 similar comment
@ghost
Copy link

ghost commented Nov 8, 2018

Travis automatic deployment:
https://pr423--dxreact.review.gnosisdev.com

W3stside
W3stside approved these changes Nov 8, 2018
View reviewed changes
Copy link
Contributor

@W3stside W3stside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope

@W3stside
Copy link
Contributor

W3stside commented Nov 8, 2018

@Velenir I'd move the branch to develop

@Velenir
Copy link
Contributor Author

Velenir commented Nov 9, 2018

@W3stside
what matters is that doc/md files end up on master, like ADD_TOKEN_REQUEST_TEMPLATE.md was merged to master first

@W3stside W3stside changed the base branch from master to develop December 4, 2018 16:48
@ghost
Copy link

ghost commented Dec 4, 2018

Travis automatic deployment:
https://pr423--dxreact.review.gnosisdev.com

1 similar comment
@ghost
Copy link

ghost commented Dec 4, 2018

Travis automatic deployment:
https://pr423--dxreact.review.gnosisdev.com

anxolin
anxolin approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Dima! I think we need this in every project :) can we you just add it as a low prio thing to do at some point. Thx!

@W3stside
Copy link
Contributor

W3stside commented Dec 5, 2018

@Velenir @anxolin can we not merge this already?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin approved these changes

@W3stside W3stside W3stside approved these changes

@c3rnst c3rnst Awaiting requested review from c3rnst

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Velenir @W3stside @anxolin