Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement split and merge for ERC-1155 collateral tokens #58

Merged
merged 2 commits into from
Jul 31, 2019

Conversation

cag
Copy link
Contributor

@cag cag commented Jul 29, 2019

Closes #56

@cgewecke
Copy link

@cag Sorry, spying on this repo to see when codechecks stuff breaks (and it did!)

I just ran clean here and am wondering if your failure was a random server glitch or something deeper....

@cag
Copy link
Contributor Author

cag commented Jul 30, 2019

Hey! I think maybe this is because the contracts won't lint anymore. I dunno why though, but the linter crashes. Let me try removing the linting from the CI script.

EDIT: Nevermind, I see there is another section in the CI logs for codechecks 🤔

@cgewecke
Copy link

Oh no. I'm going to publish a patch that catches the error and exits 0 so at least this doesn't fail CI. Also pinged codechecks to ask if they can see anything in the server logs.

Sorry about this and thanks for being (willing to be) experimented on.

@cgewecke
Copy link

0.2.9 has the graceful exit and some debugging logs... if you hit rerun on the PR build it might go green.

@cgewecke
Copy link

Lastly - I forked this repo to reproduce and got a report ok - here.

One thing I did was explicitly uninstall/re-install the gas reporter because greenkeeper lock wasn't letting it float up to latest. But idk if that's really the issue...

@cag cag merged commit bd210a7 into master Jul 31, 2019
@cag cag deleted the collateral-1155 branch July 31, 2019 17:03
@cag cag mentioned this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow ERC-1155 as collateral
2 participants