Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ERC-1155 as collateral #56

Open
cag opened this issue Jul 24, 2019 · 1 comment · Fixed by #58
Open

Allow ERC-1155 as collateral #56

cag opened this issue Jul 24, 2019 · 1 comment · Fixed by #58
Labels
enhancement New feature or request P3 Med/low - Nice to have

Comments

@cag
Copy link
Contributor

cag commented Jul 24, 2019

This would entail changing the makeup of the position ID hash payload, adding a value for distinguishing between ERC-20 and ERC-1155 tokens, as well as a value to identify the ID of a particular ERC-1155 token.
@cag cag mentioned this issue Jul 29, 2019
Merged
@cag cag closed this as completed in #58 Jul 31, 2019
@cag cag mentioned this issue Aug 6, 2019
Merged
@cag cag reopened this Aug 6, 2019
@cag
Copy link
Contributor Author

cag commented Aug 6, 2019

ERC-1155 currently won't be collateral

@auryn-macmillan auryn-macmillan added enhancement New feature or request P3 Med/low - Nice to have labels Aug 6, 2020
@cag cag mentioned this issue Dec 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request P3 Med/low - Nice to have
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement split and merge for ERC-1155 collateral tokens gnosis/conditional-tokens-contracts
2 participants
@cag @auryn-macmillan