Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy features from BidOnAddresses.sol #112

Open
vporton opened this issue Dec 10, 2020 · 6 comments
Open

Copy features from BidOnAddresses.sol #112

vporton opened this issue Dec 10, 2020 · 6 comments

Comments

@vporton
Copy link

vporton commented Dec 10, 2020

This contract has some features that ConditionalTokens.sol should but doesn't support.

Please copy some (all reasonably "copyable") features from BidOnAddresses.sol to ConditionalTokens.sol.

For example, ERC-1155 collaterals would be useful. (We can wrap ERC-20 inside a ERC-1155 wrapper; well, this wrapper wouldn't be fully compatible to ERC-1155 because we can't emit all the events, but that will work for us nevertheless.)

@cag
Copy link
Contributor

cag commented Dec 17, 2020

What features specifically do you want to see copied from that contract? Maybe we can break these features down into separate issues, and at some point a new version of the conditional tokens may be implemented.

The problem is diverting too much energy to getting folks to migrate to a new version before the value is there, which is why this repo is just collecting issues. Smart contract development is quite similar to hardware development in that respect...

@vporton
Copy link
Author

vporton commented Dec 17, 2020

What features specifically do you want to see copied from that contract? Maybe we can break these features down into separate issues, and at some point a new version of the conditional tokens may be implemented.
Yes, need to break into separate issues, but I don't plan now to work on this idea thoroughly. I suggest you to do this.

One of of the features is NxM combinations where N is the number of oracles and M is the number of markets (sets of conditional tokens).

Another is using ERC-1155 for both conditionals and collaterals.

There are more features that can be "copied".

Such features require a new version of your contract with a new API.

The problem is diverting too much energy to getting folks to migrate to a new version before the value is there, which is why this repo is just collecting issues. Smart contract development is quite similar to hardware development in that respect...

I realize that it requires work. But in some future it should be done. Well, I myself don't use it.

@cag
Copy link
Contributor

cag commented Dec 17, 2020

Just for future reference, I think #110 is related to this issue?

@vporton
Copy link
Author

vporton commented Dec 17, 2020

Just for future reference, I think #110 is related to this issue?

Yes, but take note that there is also https://github.com/vporton/conditional-tokens-contracts/tree/bid-addresses-solidity-0.7

@cag
Copy link
Contributor

cag commented Dec 17, 2020

One of of the features is NxM combinations where N is the number of oracles and M is the number of markets (sets of conditional tokens).

Forgive me for the late response. I've been trying to grok what's been written. From my current understanding, "markets" here actually means something analogous to "conditions," and NxM combinations is already possible with the current contract, even without any transactions, so it's even cheaper since these combinations exist counterfactually.

Another is using ERC-1155 for both conditionals and collaterals.

Yes, we're aware of this: #56

@vporton
Copy link
Author

vporton commented Dec 17, 2020

One of of the features is NxM combinations where N is the number of oracles and M is the number of markets (sets of conditional tokens).

Forgive me for the late response. I've been trying to grok what's been written. From my current understanding, "markets" here actually means something analogous to "conditions," and NxM combinations is already possible with the current contract, even without any transactions, so it's even cheaper since these combinations exist counterfactually.

No, there are 2 or more conditions per market.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants