Fix Insert Term Name Plugin error #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Insert terminal name" Plugin causes the following traceback
Traceback (most recent call last):
File "/Users/mattrose/Code/terminator/terminatorlib/terminator.py", line 588, in do_insert_term_name
term.feed(name)
File "/Users/mattrose/Code/terminator/terminatorlib/terminal.py", line 1709, in feed
self.vte.feed_child(text)
This PR fixes it so the plugin inserts the terminal name, as intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Insert terminal name" Plugin causes the following traceback Traceback (most recent call last):
File "/Users/mattrose/Code/terminator/terminatorlib/terminator.py", line 588, in do_insert_term_name
term.feed(name)
File "/Users/mattrose/Code/terminator/terminatorlib/terminal.py", line 1709, in feed
self.vte.feed_child(text)
This PR fixes it so the plugin inserts the terminal name, as intended.