Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detachable tabs feature to preferences #698

Merged

Conversation

zpalmtree
Copy link
Contributor

Fixes #697.

Not sure why so much markup got changed, guess some new glade version thing.

@Vulcalien Vulcalien added the enhancement New feature or request label Feb 14, 2023
@Vulcalien
Copy link
Member

I tested it and it seems to work fine. Thanks for the help!

The initialization code in prefseditor.py is in the wrong function (profile instead of global), but I made a PR to your fork.
Other than that, seems all good!

…ence

Detachable tabs: reposition preferences code
@zpalmtree
Copy link
Contributor Author

Merged your PR, thanks for the help!

@mattrose
Copy link
Member

mattrose commented Mar 1, 2023

I'm probably blind, but I can't see the detachable tabs check box when I pull your code in? Can you put up a screenshot or something to help me?

@zpalmtree
Copy link
Contributor Author

I'm probably blind, but I can't see the detachable tabs check box when I pull your code in? Can you put up a screenshot or something to help me?

It should appear here:
image

Perhaps you have an existing terminator instance open? When I was testing out my changes if I had any other terminators open, it would reuse the old code and not reflect any new changes.

Copy link
Contributor

@nautics889 nautics889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works fine on for me.

I see a toggle in preferences and it works correctly when i disable/enable one:
Screenshot 2023-04-17 234716

Thank you!

@mattrose
Copy link
Member

all good now, sorry about the wait.

@mattrose mattrose merged commit e0592ea into gnome-terminator:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable detachable tabs flag
4 participants