Terminal ctrl+mousewheel: do not try to zoom if shift is pressed #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm so sorry I haven't merged this in, I'm just super-busy right now. I haven't forgotten about you, I just don't seem to have any time right now. Thank you so much for. putting in this work. |
|
No worries! It's not that urgent anyway, it sure can wait |
|
Thanks @Vulcalien. Sorry for the wait! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #606 (maybe partially)
The intended feature
To zoom/unzoom the font, it is possible to do
ctrl+mousewheelin the terminal.To do fast scrolling, there is
shift+mousewheel.Problem
However, ctrl+shift+mousewheel will zoom/unzoom the font as well, ignoring the shift key.
Solution
In the code, check if the modifier is only
ctrl, so that the zoom/unzoom is not triggered when doingctrl+shift+mousewheelQuestion
Should we check for things like
ctrl+alt+mousewheel,ctrl+super+mousewheeland so on as well?