-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unzoom terminal on interaction #553
Unzoom terminal on interaction #553
Conversation
There is a bug: strange behavior for navigation and rotation
Navigation is consistent
Now it works, but there is an annoying bug: after an unzoom, the terminal is moved by a single pixel, making the navigation after an unzoom inconsistent. It's a different issue, so I'll see if I can fix that with another PR. Edit: I think this is ready for merge, if no problems are found here. |
So, I have to admit, I'm not clear on what the problem is with this issue. That seems to be a "me" issue, as it was clear to you, but at the same time, I'm hesitant to merge something that you think is not quite complete because I have no idea 😄 . If you could open the other PR and then I can merge them in at the same time, that'd be great. |
I think I'm starting to figure this one out after having looked at it and read your patch, and it looks good to me. If you could either open a new bug or come up with a new PR for the other issue you mentioned, that would be great. That way there's some evidence of it other than in a closed PR, in case you get busy with something else, or there's something else blocking your fix. |
Here is how to reproduce the issue.
Current behavior: Desired behavior: Other examples of "interactions" that should trigger an unzoom are a split, a rotation, a "new tab". This is more or less how tmux handles the behavior as well. I will make the new issue. |
Merging. Sorry about the wait. |
Finally wrote the issue, I wanted to make sure to see the real problem. Apparently, it's focus lost. |
Fixes #550
These changes make a zoomed/maximized terminal unzoom on interactions such as: creating a new tab, resizing the terminal, splitting it etc...
There are still problems with two of these interactions: rotating the terminal and moving to another terminal.
The function
get_allocation()
returns(width: 1, height: 1, ...)
right after an unzoom.The bug can be replicated with a few terminals (I use one on the left, one top-right, one bottom-right). Zoom the bottom-right one and try to rotate or move to the top-right terminal.
What I get for the rotation is that one terminal is big, the other two are very small.