Bug Fix: hide_window keybinding ignores Shift key #510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #509
The shift key gets ignored by the global Keybinder. That's not a bug in the library, it's a misconfiguration.
By default, keybinder uses "cooked accelerators".
I quote from the issue comments.
There is this C function
keybinder_set_use_cooked_accelerators
So yeah, we just had to disable them using this:
There is another issue about hide_window not working (#427). I doubt it's related to this, I think that one is about Wayland.