-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move titlebar settings to profiles (#379) #481
Conversation
Thanks so much for this. I'm having a down day today but I'll look at this soon. What happens when you have a config file that specifies the titlebar colors in the old place and you upgrade? |
Don't worry, I'll not change the PR. |
It seems to just delete the old settings once terminator writes the config file, as expected. However I just found a little bug in the GUI, that doesn't update some of the titlebar settings when switching between profiles. I think I can fix it before the PR is merged. Edit: I want to fix this before merging. |
Awesome, thanks! |
Don't worry I'll wait for your other fix before merging. Thanks again! |
Ok perfect, it should be fine now. I had forgotten to move some "update GUI" code. |
This seems to do the right thing |
Thanks again! Much Appreciated! |
Glad to help! |
Grr. Documentation. If you want to update the documentation and screenshots at https://github.com/gnome-terminator/docs/blob/master/source/preferences.rst that would be fantastic! |
This PR is about the issue #379.
Since the titlebar settings are mostly about colors and fonts, it would make sense to have different settings for different profiles.
Pros of this:
Cons:
What I did
First, I wanted to test whenever it was possible or not to move those settings. I found out it is possible, and I had to do very little changes to the code.
The only one that cannot be moved is "Titlebar at bottom", because there is some code that adds it when the terminal is created (however, I think it might be possible).
Then, I went to fix the GUI.
The second commit just updates
preferences.glade
to the format used by Glade 3.38.2. (note 1)The third commit contains all the GUI changes. Basically, I just copy-pasted some of the components from the Global menu to the new Profiles>Titlebar menu.
I chose to put the titlebar menu at the end, just to avoid moving the other ones, that I think would confuse the long term users.
The "titlebar at bottom" setting is now inside the Appearance group of the Global settings.
Also, I fixed some of the grids in the GUI, that had empty rows or columns. This should not affect the GUI and I didn't notice any difference while reviewing it.
Last thing, the minimum window size was reduced. (note 2)
This is the Titlebar menu
Notes