Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed geometry hints #416

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Fixed geometry hints #416

merged 1 commit into from
Apr 9, 2021

Conversation

Vulcalien
Copy link
Member

@Vulcalien Vulcalien commented Apr 8, 2021

I tried to use Window geometry hints, but it didn't work.
I tested this on: Debian 11 (all updates), Debian 10 and Ubuntu 20.04.

Details:
it seems that "set_geometry_hints" wants "None" as first argument.
Also, it's necessary to disable geometry hints, if we want to avoid restarting terminator.
So I wrote a little function that does that.

@mattrose
Copy link
Member

mattrose commented Apr 8, 2021

Can you give me an idea on how to test this?

@Vulcalien
Copy link
Member Author

Sure!
So to reproduce the bug:

  • I go to Terminator Preferences, select "Window geometry hints" and close Preferences
  • try to resize the Terminator window

On all the distros I listed, it just ignores the geometry hints and resizes "smoothly".
Even if I restart Terminator, still same problem.

The problem should not be the config file, because it contains this:

[global_config]
  geometry_hinting = True
  ...

With my modifications:

  • all Terminator instances must be closed (I guess it runs the older version otherwise)
  • again, select "Window geometry hints" in Preferences
  • I do python3 terminator to run it

It should work and resize correctly.

@Vulcalien
Copy link
Member Author

Also, some additional details: I tested the new version with the same config file and also after deleting the config file. It works on both cases.

About the disable_geometry_hints function:
without calling that function, if I go to Preferences and uncheck "Window geometry hints" I would need to restart Terminator to restore the "smooth" resize.

About using None instead of self:
I've read that around GNOME 3.20 the behavior changed in the C library. It seems it should replace every parameter with null. Maybe for a bug the python library does not do this correctly, I'm not sure.

@mattrose mattrose merged commit ebe5844 into gnome-terminator:master Apr 9, 2021
@mattrose
Copy link
Member

mattrose commented Apr 9, 2021

Works. Pulling. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants