Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favorites/Bookmarks ??? #706

Closed
Foul opened this issue Jan 28, 2023 · 2 comments
Closed

Favorites/Bookmarks ??? #706

Foul opened this issue Jan 28, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@Foul
Copy link

Foul commented Jan 28, 2023

Hello, would it be possible to add Favorites/Bookmarks in this terminal ?

I'm using Konsole by default and i swould like this feature in Terminator plz.

Thx.
@mattrose mattrose added the enhancement New feature or request label Jan 31, 2023
vssdeo added a commit to vssdeo/terminator that referenced this issue Aug 8, 2023
@vssdeo
-[bug 706] Favorites-Bookmarks-Plugini gnome-terminator#706
fd73eb8 
- changes to config.py to support bookmarks, later this should be done in plugin itself
- adding bookmark.py plugin
- minor modification for current working dir
vssdeo added a commit to vssdeo/terminator that referenced this issue Aug 8, 2023
@vssdeo
[bug 706] Favorites-Bookmarks-Plugini gnome-terminator#706
0d9f69b 
- comments and TODO updates
@vssdeo
Copy link
Contributor

vssdeo commented Aug 8, 2023

Putting in some code to check things via Plugin.

DEPENDENCIES: KeyBind Util #806
Known Issues:

-keyboard short cuts have issue on new windows, #681 puts in a solution to reload but that needs to be verified by others also. -GUI works.
-if two windows are opened, sometimes the second one while loading bookmark does not load the directory for the first time.

Usage:

<Alt>b to add 
<Alt>r to remove
or right click and use via menu

  • sub-menu via right click->bookmarks->urls->(act menu)

  • bookmark plugin, basic features

  • Requires support of KeyBindUtil from Plugin which assists short cuts

  • may be edit option can be added via Preferences Plugin window

  • config has = so rhs can be used for tags

  • TODO: config changes if can be brought to plugin code

-       support in Preferences window
-       limit on number of urls via Preferences ?
-       display shortcuts in menu
-       selection of urls from keyboard and tag support

bookmark_plugin

This was referenced Aug 8, 2023
Closed
Closed
Merged
vssdeo added a commit to vssdeo/terminator that referenced this issue Sep 4, 2023
@vssdeo
-[bug 706] Favorites-Bookmarks-Plugini gnome-terminator#706
7045570 
- adding bookmark.py plugin
- minor modification for current working dir
- more additions like shortcuts, tags can be added on
vssdeo added a commit to vssdeo/terminator that referenced this issue Sep 4, 2023
@vssdeo
[bug 706] Favorites-Bookmarks-Plugini gnome-terminator#706
f51cbdc 
- removed unused code
@vssdeo vssdeo mentioned this issue Sep 4, 2023
Closed
vssdeo added a commit to vssdeo/terminator that referenced this issue Sep 10, 2023
@vssdeo
[bug 706] 706-Favorites-Bookmarks-Plugin-next gnome-terminator#706
17e343f 
- bookmark plugin, basic features, support in UI in prefs window (via plugin)
- tags feature, can be used to build xml later
-
- TODO:
-       display shortcuts in menu
-       selection of urls from keyboard
- Defaults:
- press <Alt>b (see below) to add current dir in bookmark <Alt>r to remove
- sub-menu via right click->bookmarks->urls->(act menu) and
- Prefs->Plugins->BookmarkPlugin
vssdeo added a commit to vssdeo/terminator that referenced this issue Sep 12, 2023
@vssdeo
[bug 706] - 706-Favorites-Bookmarks-Plugin gnome-terminator#706
e640c3e 
-fixed error when no bookmark section is there in config
vssdeo added a commit to vssdeo/terminator that referenced this issue Sep 13, 2023
@vssdeo
[bug 06] - 706-Favorites-Bookmarks-Plugin gnome-terminator#706
54daab3 
-using feed_child instead of passing command to terminal
-helps to keep the terminal or window alive else it closes after executing the command
vssdeo added a commit to vssdeo/terminator that referenced this issue Sep 14, 2023
@vssdeo
[bug 706] 706-Favorites-Bookmarks-Plugin gnome-terminator#706
b0055c3 
- bash shell was adding starting spaces while fetching last exec command, so stripping spaces
vssdeo added a commit to vssdeo/terminator that referenced this issue Sep 14, 2023
@vssdeo
[bug 706] 706-Favorites-Bookmarks-Plugin gnome-terminator#706
3fa1373 
- added support for directly launching plugin in preferences and with that plugin selected, this one for bookmarks
vssdeo added a commit to vssdeo/terminator that referenced this issue Sep 14, 2023
@vssdeo
[bug 706] 706-Favorites-Bookmarks-Plugin gnome-terminator#706
10e459c 
- changes to have default bookmark tag as global
vssdeo added a commit to vssdeo/terminator that referenced this issue Sep 14, 2023
@vssdeo
[bug 706] 706-Favorites-Bookmarks-Plugin gnome-terminator#706
df94361 
-fixed error due to flag_found in update_bookmark
vssdeo added a commit to vssdeo/terminator that referenced this issue Oct 8, 2023
@vssdeo
[bug 706] 706-Favorites-Bookmarks-Plugin gnome-terminator#706
86337ad 
- modified custom command plugin to have bookmarks
- added keybindings for directly adding or launch the custom command menu
- made name parsing of the custom command optional
@vssdeo
Copy link
Contributor

vssdeo commented Oct 8, 2023 •
edited
Loading

Hi. Have removed my old separate bookmark plugin and have added the functionality to custom command plugin. Would be great if anyone can test / try Ref: https://github.com/vssdeo/terminator/tree/706-Favorites-Bookmarks-Plugin

Changes rest on my branch not putting up a pull request now.

To test, just merge my changes or use branch. enable custom command plugin. Default keybindings are <Alt>b or direct adding <Shift><Alt>b to launch custom command pref window.

Current changes:
- modified custom command plugin to have bookmarks
- added keybindings for directly adding or launch the custom command menu
- made name parsing of the custom command optional

I made parsing of custom command name optional keeping old behavior default. As I find, most of the times people would want to command name to be same as command and not parse it to submenus every time.

Once things seem ok I can merge tags functionality also.

GitHub - vssdeo/terminator at 706-Favorites-Bookmarks-Plugin - GitHub
multiple GNOME terminals in one window. Contribute to vssdeo/terminator development by creating an account on GitHub.
bookmark-add-1
bookmark-add-2
bookmark-add-3

vssdeo added a commit to vssdeo/terminator that referenced this issue Oct 16, 2023
@vssdeo
[bug 706] 706-Favorites-Bookmarks-Plugin gnome-terminator#706
a5ddcbe 
- the dialog window taking command for bookmark via shortcut keybinding will have focus on OK Button for faster interaction
- fixed a transient window issue for loading pref window via shortcut and context menu
- filed new command text area  was getting filled with last command
- fixed list store init
@mattrose mattrose closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattrose @Foul @vssdeo