Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip failed txs in Portal Loop reset #3699

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

zivkovicmilos
Copy link
Member

Description

This PR sets the Portal Loop to skip backing up and looping failed transactions during a loop run.

@zivkovicmilos zivkovicmilos self-assigned this Feb 7, 2025
@zivkovicmilos zivkovicmilos added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Feb 7, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Feb 7, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

No automated checks match this pull request.

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@moul
Copy link
Member

moul commented Feb 7, 2025

Addresses #3478
Fixes #3663

@moul
Copy link
Member

moul commented Feb 7, 2025

for people looking for what this PR does, here is the main commit: https://github.com/gnolang/tx-archive/pull/56/files

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@zivkovicmilos zivkovicmilos merged commit c41a056 into master Feb 7, 2025
69 checks passed
@zivkovicmilos zivkovicmilos deleted the dev/zivkovicmilos/pl-update branch February 7, 2025 15:25
thehowl added a commit that referenced this pull request Feb 10, 2025
This PR follows #3699 to skip failed transactions on `gnodev` while
reloading.

---------

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Co-authored-by: Morgan Bazalgette <morgan@morganbaz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Development

Successfully merging this pull request may close these issues.

extend txports to export transaction status
4 participants