feat(examples): add p/demo/avl/list #3324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: moul <94029+moul@users.noreply.github.com>
github-actions
bot
added
the
🧾 package/realm
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
thehowl
reviewed
Dec 11, 2024
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
thehowl
reviewed
Dec 20, 2024
| count := endIndex - startIndex | ||
| result := make([]interface{}, count) | ||
|
|
||
| // Fill the slice from end to start to maintain correct order |
thehowl
approved these changes
Dec 20, 2024
Comment on lines
245
to
249
| l.tree.IterateByOffset(0, size, func(_ string, value interface{}) bool { | ||
| values[i] = value | ||
| i-- | ||
| return false | ||
| }) |
There was a problem hiding this comment.
If reverse here is necessary, you can use ReverseIterateByOffset and call fn() directly
Comment on lines
285
to
292
| l.tree.IterateByOffset(0, size, func(_ string, value interface{}) bool { | ||
| values[i] = value | ||
| i-- | ||
| return false | ||
| }) | ||
|
|
||
| // Add values to new list in correct order | ||
| for _, value := range values { |
thehowl
approved these changes
Dec 20, 2024
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
…o dev/moul/avllist
Signed-off-by: moul <94029+moul@users.noreply.github.com>
thehowl
added a commit
that referenced
this pull request
Dec 20, 2024
the tests were there, but apparently `slicesEqual` had a bug. lol. This comes from #3324, and makes it so that IterateByOffset and ReverseIterateByOffset use the correct order. I changed the `descending` argument of the underlying TraverseByOffset to match it with avl.Node.TraverseInRange. --------- Signed-off-by: moul <94029+moul@users.noreply.github.com> Co-authored-by: moul <94029+moul@users.noreply.github.com>
albttx
pushed a commit
that referenced
this pull request
Jan 10, 2025
the tests were there, but apparently `slicesEqual` had a bug. lol. This comes from #3324, and makes it so that IterateByOffset and ReverseIterateByOffset use the correct order. I changed the `descending` argument of the underlying TraverseByOffset to match it with avl.Node.TraverseInRange. --------- Signed-off-by: moul <94029+moul@users.noreply.github.com> Co-authored-by: moul <94029+moul@users.noreply.github.com>
albttx
pushed a commit
that referenced
this pull request
Jan 10, 2025
Could become the preferred method for managing top-level lists. It can likely be utilized extensively in the existing codebase, potentially for most instances involving a top-level slice or those involving an avl.Tree using a seqid. --------- Signed-off-by: moul <94029+moul@users.noreply.github.com> Co-authored-by: Morgan <morgan@morganbaz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could become the preferred method for managing top-level lists.
It can likely be utilized extensively in the existing codebase, potentially for most instances involving a top-level slice or those involving an avl.Tree using a seqid.