feat: add p/moul/mdtable #3100
Merged
feat: add p/moul/mdtable #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3100 +/- ##
=======================================
Coverage 63.77% 63.77%
=======================================
Files 548 548
Lines 78681 78681
=======================================
Hits 50180 50180
- Misses 25117 25121 +4
+ Partials 3384 3380 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: moul <94029+moul@users.noreply.github.com>
leohhhn
approved these changes
Nov 12, 2024
r3v4s
pushed a commit
to gnoswap-labs/gno
that referenced
this pull request
Dec 10, 2024
Can be useful for gnolang#3096. --------- Signed-off-by: moul <94029+moul@users.noreply.github.com>
albttx
pushed a commit
that referenced
this pull request
Jan 10, 2025
Can be useful for #3096. --------- Signed-off-by: moul <94029+moul@users.noreply.github.com>
moul
added a commit
that referenced
this pull request
Feb 4, 2025
This realm is a good example of reusing and integrating some of my recently added libraries: - `p/moul/md` #2819 - `p/moul/mdtable` #3100 - `p/moul/realmpath` #3257 - `p/moul/txlink` #3289 - `p/moul/collection` #3321 - `p/demo/avl/pager` #2584 It helped me identify that `txlink` was not escaping the arguments, which resulted in invalid links. (fixed in #3682) Additionally, it provided me with a better understanding of: - The shortcomings of the `p/moul/md` API, particularly regarding `"\n"` handling - The need for improved management of the pager for `p/moul/collection` - What kind of UI improvements we could need on gnoweb. #3355 Demo: https://github.com/user-attachments/assets/4b20cee8-b8d7-4eba-90a8-5b87a3c19521 I also suggest you to look at the `filetest.gno` file. I believe we should proceed with the merge, to inspire others to create similar composed realms. However, I have a few improvement ideas: 1. Extract most of the generic logic into a `p/moul/present`. 2. Consider either making r/moul/present importable by `r/coreteam/present` to create a hub for presentations from all teammates, or the opposite: make `r/coreteam/present` the content source and allow `r/moul/present` to display a subset where `author="moul"` What are your thoughts? 3. Clean up the code using an improved `p/moul/md` and possibly new `p/` generic utilities. Depenes on #3682 --------- Signed-off-by: moul <94029+moul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be useful for #3096.