feat(gnovm): packages loader #2932

n0izn0iz · 2024-10-10T11:30:05Z

WIP

Continuation of #2201
Taking #2904 into account

This implements a Load function with a similar interface to the packages.Load go function

Contributors' checklist...

Added new tests, or not needed, or not feasible
Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
Updated the official documentation or not needed
No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
Added references to related issues and PRs
Provided any useful hints for running manual tests
Added new benchmarks to generated graphs, if any. More info here.

…esolver

Signed-off-by: Norman Meier <norman@samourai.coop>

…no-resolver

codecov · 2024-10-10T11:32:47Z

Codecov Report

Attention: Patch coverage is 73.91304% with 12 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
gno.land/pkg/integration/pkgloader.go	75.00%	4 Missing and 2 partials ⚠️
gno.land/pkg/gnoland/genesis.go	70.00%	2 Missing and 1 partial ⚠️
gno.land/cmd/gnoland/start.go	75.00%	0 Missing and 1 partial ⚠️
gno.land/pkg/integration/testscript_gnoland.go	0.00%	0 Missing and 1 partial ⚠️
gno.land/pkg/keyscli/run.go	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Signed-off-by: Norman Meier <norman@samourai.coop>

…ve download to own file Signed-off-by: Norman Meier <norman@samourai.coop>

Signed-off-by: Norman Meier <norman@samourai.coop>

moul · 2024-10-11T15:30:03Z

examples/gno.land/gno.mod

@@ -0,0 +1 @@
+module gno.land


do we need this file?

if we need it, please explain in a comment.

please see #2904 (comment) and tell me what you think

I think the best would be to have a gno.work file at repo root to support multiple modules in a monorepo
But in that case we need to implement the gno work commands

moul · 2024-10-11T15:32:03Z

gnovm/tests/machine_test.go

@@ -40,7 +40,7 @@ func TestMachineTestMemPackage(t *testing.T) {
 					Name: tt.name,
 					F: func(t2 *testing.T) { //nolint:thelper
 						rootDir := filepath.Join("..", "..")
-						store := TestStore(rootDir, "test", os.Stdin, os.Stdout, os.Stderr, ImportModeStdlibsOnly)
+						store := TestStore(rootDir, "test", nil, os.Stdin, os.Stdout, os.Stderr, ImportModeStdlibsOnly)


create a variable that you set to nil, so we now what is this parameter.

done in 0123512

gnovm/pkg/packages/download.go

moul · 2024-10-11T15:35:17Z

gnovm/pkg/packages/download.go

+func DownloadModule(pkgPath string, dst string) error {
+	modFilePath := filepath.Join(dst, ModfileName)
+	if _, err := os.Stat(modFilePath); os.IsNotExist(err) {
+		fmt.Fprintln(os.Stderr, "gno: downloading", pkgPath)


we usually don't use os.StdXXX, but stdouterr from a struct (io something) which is passed when needed.

done in e648305

Signed-off-by: Norman <norman@samourai.coop>

featuring: - [X] **Lazy reload**: Super fast reload, only loading the needed packages for the current directory package. - [x] **Chain resolver**: You can change the gnodev resolving process so it can resolve packages on-chain and configure a local fallback, allowing you to try your package against the chain before submitting it. - This will probably be updated when #2932 & #3123 will be merged - [x] **Staging Mode**: `gnodev` now starts from the current directory by default. The staging subcommand will reproduce previous behaviors by loading and monitoring the entire example folder. <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests </details> --------- Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com> Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com> Co-authored-by: Morgan <git@howl.moe> Co-authored-by: Morgan <morgan@morganbaz.com>

n0izn0iz · 2025-02-25T18:05:03Z

notes from morgan from call

gno test ./r/morgan/guestbook -> should not automatically load other packages from $PWD
	=> cd ./r/morgan/guestbook; gno test . -> should be the same as above
gno test ./r/morgan/guestbook -> should not automatically load other packages from $GIT_ROOT
	=> better to have a gno.work, even though i don't like it

gno monorepo gno.mod:
	module gno.land
a package on the monorepo cannot specify a package that only exists on-chain
	import "gno.land/p/demo/avl" // should try to fetch locally, and fail if it doesn't exist

gnoswap monorepo gno.mod(s):
	contract/r/gnoswap/gno.mod -> module gno.land/r/gnoswap; replace gno.land/p/gnoswap/... => ../../p/gnoswap
	contract/p/gnoswap/gno.mod -> module gno.land/p/gnoswap

"monorepo" of project by same author:
	gno.land/r/morgan/foo
		// part of the same project
		import "gno.land/p/morgan/foo/baz"
		// independent package by same author
		import "gno.land/p/morgan/seqid"

realms/gno.mod
	module gno.land/r/teritori/socialdapp; replace gno.land/p/teritori/socialdapp -> ../packages
gno.land/p/teritori/socialdapp
	module gno.land/p/teritori/socialdapp

outside gno.mod:
	module gno.land/r/demo/gnochess
	import "gno.land/p/demo/avl" // should try to fetch on-chain

thehowl and others added 8 commits May 26, 2024 13:41

copy over from gnoutil pr

01b0719

remove util_test

232834c

Merge branch 'master' of github.com:gnolang/gno into dev/morgan/gno-r…

f378217

…esolver

linter fixes

8afeacf

tmp: gno list

808061d

Signed-off-by: Norman Meier <norman@samourai.coop>

tmp

2c5d604

Signed-off-by: Norman Meier <norman@samourai.coop>

tmp: working

dfc0881

Signed-off-by: Norman Meier <norman@samourai.coop>

chore: merge remote-tracking branch 'origin/master' into dev/morgan/g…

a35050c

…no-resolver

github-actions bot assigned n0izn0iz Oct 10, 2024

github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Oct 10, 2024

n0izn0iz added 4 commits October 10, 2024 14:47

feat: match mapping

7c7165f

Signed-off-by: Norman Meier <norman@samourai.coop>

fix: test and lint

1c3a830

Signed-off-by: Norman Meier <norman@samourai.coop>

fix: partially fix transpile

f95e4bb

Signed-off-by: Norman Meier <norman@samourai.coop>

tmp: support loaded pkgs in test store

2d990e5

Signed-off-by: Norman Meier <norman@samourai.coop>

n0izn0iz mentioned this pull request Oct 11, 2024

rfc: the future of gno.mod #2904

Open

n0izn0iz added 6 commits October 11, 2024 12:59

tmp: better Module info

6995485

Signed-off-by: Norman Meier <norman@samourai.coop>

tmp: follow go resolver logic

fb8d518

Signed-off-by: Norman Meier <norman@samourai.coop>

fix: resolver usage in test

1c51509

Signed-off-by: Norman Meier <norman@samourai.coop>

chore: mod tidy

da65417

Signed-off-by: Norman Meier <norman@samourai.coop>

chore: ignore draft

4a8401a

Signed-off-by: Norman Meier <norman@samourai.coop>

chore: rename importer -> packages like go, break import cycle and mo…

e792771

…ve download to own file Signed-off-by: Norman Meier <norman@samourai.coop>

n0izn0iz changed the title ~~feat(gnovm): package resolver lib~~ feat(gnovm): packages loader Oct 11, 2024

chore: lint and fmt

08fbd84

Signed-off-by: Norman Meier <norman@samourai.coop>

moul reviewed Oct 11, 2024

View reviewed changes

gnovm/pkg/packages/download.go Outdated Show resolved Hide resolved

moul reviewed Oct 11, 2024

View reviewed changes

n0izn0iz and others added 20 commits February 2, 2025 03:14

chore: remove merge artifact

33f90ca

Signed-off-by: Norman <norman@samourai.coop>

fix: tests

d5a083b

Signed-off-by: Norman <norman@samourai.coop>

fix: remove dev artifact

282b818

Signed-off-by: Norman <norman@samourai.coop>

Merge branch 'master' into gno-resolver

723096c

fix: revert transpile invocation

d35e1ff

Signed-off-by: Norman <norman@samourai.coop>

fix: include workspace modules in gno test

62f0f9d

Signed-off-by: Norman <norman@samourai.coop>

chore: revert transpile invocation change

44bff74

Signed-off-by: Norman <norman@samourai.coop>

fix: test

8fe26c8

Signed-off-by: Norman <norman@samourai.coop>

chore: lint

c6b1f3b

Signed-off-by: Norman <norman@samourai.coop>

chore: remove dev artifact

315ac5d

Signed-off-by: Norman <norman@samourai.coop>

fix: hardcoded dev path in test

80c68ea

Signed-off-by: Norman <norman@samourai.coop>

fix: mod graph

19e7f5f

Signed-off-by: Norman <norman@samourai.coop>

chore: miss push

babff8f

Signed-off-by: Norman <norman@samourai.coop>

fix: allow to ignore stdlibs in sort and sort mempkg files

4686c7c

Signed-off-by: Norman <norman@samourai.coop>

Merge branch 'master' into gno-resolver

45e8115

fix: ignore stdlibs in genesis gen

f7d3de8

Signed-off-by: Norman <norman@samourai.coop>

chore: add todo

4923559

Signed-off-by: Norman <norman@samourai.coop>

fix: include other files in pkg

98ccddd

Signed-off-by: Norman <norman@samourai.coop>

fix: include other files in mempkg

52bcc43

Signed-off-by: Norman <norman@samourai.coop>

fix: gnodevé

31b92be

Signed-off-by: Norman <norman@samourai.coop>

n0izn0iz force-pushed the gno-resolver branch from 5090ff2 to 31b92be Compare February 8, 2025 16:39

n0izn0iz added 6 commits February 8, 2025 23:57

chore: Merge remote-tracking branch 'origin/master' into gno-resolver

c93c225

Signed-off-by: Norman <norman@samourai.coop>

chore: remove 'SelfContained'

568836c

Signed-off-by: Norman <norman@samourai.coop>

chore: add testdata

847f325

Signed-off-by: Norman <norman@samourai.coop>

chore: rm uneeded instance

a673ecc

Signed-off-by: Norman <norman@samourai.coop>

chore: revert uneeded change

e07af66

Signed-off-by: Norman <norman@samourai.coop>

chore: add tests and cut uneeded features

6735ef4

Signed-off-by: Norman <norman@samourai.coop>

thehowl mentioned this pull request Feb 25, 2025

[chain] Unable to deploy module with a single top-level gno.mod, with multiple sub-packages without gno.mods #2141

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(gnovm): packages loader #2932

feat(gnovm): packages loader #2932

n0izn0iz commented Oct 10, 2024 •

edited

Loading

codecov bot commented Oct 10, 2024 •

edited

Loading

moul Oct 11, 2024

n0izn0iz Oct 11, 2024

n0izn0iz Oct 11, 2024 •

edited

Loading

moul Oct 11, 2024

n0izn0iz Oct 11, 2024

moul Oct 11, 2024

n0izn0iz Oct 11, 2024

n0izn0iz commented Feb 25, 2025

feat(gnovm): packages loader #2932

Are you sure you want to change the base?

feat(gnovm): packages loader #2932

Conversation

n0izn0iz commented Oct 10, 2024 • edited Loading

codecov bot commented Oct 10, 2024 • edited Loading

Codecov Report

moul Oct 11, 2024

Choose a reason for hiding this comment

n0izn0iz Oct 11, 2024

Choose a reason for hiding this comment

n0izn0iz Oct 11, 2024 • edited Loading

Choose a reason for hiding this comment

moul Oct 11, 2024

Choose a reason for hiding this comment

n0izn0iz Oct 11, 2024

Choose a reason for hiding this comment

moul Oct 11, 2024

Choose a reason for hiding this comment

n0izn0iz Oct 11, 2024

Choose a reason for hiding this comment

n0izn0iz commented Feb 25, 2025

n0izn0iz commented Oct 10, 2024 •

edited

Loading

codecov bot commented Oct 10, 2024 •

edited

Loading

n0izn0iz Oct 11, 2024 •

edited

Loading