Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gnokey): update gnokey verify and tests #2333

Closed

Conversation

thinhnx-var
Copy link
Contributor

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Link to this issue: #2311
This PR changes the Verify() to read the signed doc, verify the exactly original message hash that was signed.
It also adds chainid, account-number, account-sequence config flag to the gnokey verify command.

The sign function now expose the hex-format of signature to the IO in oder to feed the verify as an argument. I think we need better way for user to verify their signed document, which currently need this hex-format (#2272)

What do you think about this change?

@thinhnx-var thinhnx-var requested review from jaekwon and a team as code owners June 12, 2024 04:42
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tm2/pkg/crypto/keys/client/verify.go 84.61% 2 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@leohhhn
Copy link
Contributor

leohhhn commented Jun 12, 2024

Hey @thinhnx-var thanks for this - can you please check why the CI is failing and fix it?

@thinhnx-var thinhnx-var changed the title [gnokey] update gnokey verify and tests feat(gnokey): update gnokey verify and tests Jun 12, 2024
@thinhnx-var
Copy link
Contributor Author

@leohhhn yeah sure. Maybe CI failed because CI-Lint. I gonna fix it up.

@thinhnx-var
Copy link
Contributor Author

@leohhhn
Can you please review this. I ( and I think others) have problems when using current version of gno sign so I think it should be good to merge this.

@leohhhn
Copy link
Contributor

leohhhn commented Sep 11, 2024

Hey! I will take a look. Please stop clicking "merge master". This is annoying and spammy, and will not get your PR reviewed faster. You should only merge in master if there are conflicts to be resolved.

@Kouteki Kouteki added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Oct 3, 2024
@jefft0 jefft0 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Oct 4, 2024
@jefft0
Copy link
Contributor

jefft0 commented Oct 4, 2024

Removed the "review team" label because this is already reviewed by leohhhn.

Co-authored-by: Jeff Thompson <jeff@berty.tech>
@jefft0 jefft0 mentioned this pull request Dec 2, 2024
@zivkovicmilos zivkovicmilos added the don't merge Please don't merge this functionality temporarily label Dec 16, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 16, 2024

🛠 PR Checks Summary

🔴 Maintainers must be able to edit this pull request (more info)
🔴 The pull request head branch must be up-to-date with its base (more info)

Manual Checks (for Reviewers):
  • SKIP: Do not block the CI for this PR
  • The pull request description provides enough details
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🔴 Maintainers must be able to edit this pull request (more info)
🔴 The pull request head branch must be up-to-date with its base (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: VAR-META-Tech/gno)

Then

🔴 Requirement not satisfied
└── 🔴 Maintainer can modify this pull request

The pull request head branch must be up-to-date with its base (more info)

If

🟢 Condition met
└── 🟢 On every pull request

Then

🔴 Requirement not satisfied
└── 🔴 Head branch (VAR-META-Tech:dev-thinhnx/feat_gno_verify) is up to date with base (master): behind by 243 / ahead by 14

Manual Checks
**SKIP**: Do not block the CI for this PR

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)

Can be checked by

  • team core-contributors

@thehowl
Copy link
Member

thehowl commented Feb 20, 2025

Closing this as stale, and the author is unresponsive. Feel free to reopen

@thehowl thehowl closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't merge Please don't merge this functionality temporarily 📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants