-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(amino): Add TypeDesc Amino implementation and TypedValue
marshaler
#2113
Conversation
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
e0997a5
to
9dd01a1
Compare
This PR is stale because it has been open 3 months with no activity. Remove stale label or comment or this will be closed in 3 months. |
@gfanton I have this PR in my review queue from forever ago. Do you still need reviews? |
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
PS: This PR is still in draft, but I would welcome any feedback on it
This PR has two main objectives. The first is to add a
TypeDesc
method implementation to Amino, allowing a type to self-describe. The second is to introduce a new package,gnoamino
, dedicated to (un)marshaling Gno types, starting withgnolang.TypedValue
and itsTypedValueWrapper
, which implements theTypeDesc
Amino method.Most of the methods in
TypedValueWrapper
are inspired by or copied fromgnonative.go
. They are exported here for several reasons:gnonative
are intended for general use and may be removed later, while the ones here are focused solely on marshaling and unmarshaling.TypedValue
, simplifying its management.Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description