-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a User I want to have both parse ary and parse stream options #122
Comments
@LocoDelAssembly, for using pipes in Ruby code It is possible to avoid streaming method by reducing the size of a batch to 1. So I suspect we can close this ticket for now. An option for the batch size is added already. |
The v1.0.0 code is located in 102-clean branch, an example of running 1 name at a time is
|
Looks like we need to have streaming option, because otherwise pipe solution becomes too hackish |
It seems that b47531d |
Looks like we do need a stream. I have an expreimental package to order unordered streams, and I will try to use it here. https://github.com/gnames/gnlib/blob/master/organizer/organizer.go |
Currently, gnpaser moved to use parsing by chunks instead of parsing a stream. This implementation allows to have the same order of input and output, but it is not good to using gnpaser as a "pipe in pipe out", because it collects names into a "buffer" until they are parsed, while pipe in pipe out approach sends and receives names one by one.
The text was updated successfully, but these errors were encountered: