This repository was archived by the owner on Feb 6, 2023. It is now read-only.
New light theme #17
Merged
New light theme #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed the _apply_base_theme to apply AFTER palette is set, because you can't change the theme until setPalette is called. You won't notice this when there's only one theme, but when you try to switch between 2, it becomes apparent that the change only succeeds after you setPalette twice, which is due to it being called AFTER _apply_base_theme, instead of before.
The application might not have a border to see the default title, but it is an application and visible on the taskbar. Rest assured that the system WILL add a title to your application, and your taskbar application will say "Python" instead of the proper window title, which is UGLY. We SHOULD be setting the applications title as well. There's no way to set this without ugly code, it belongs in the official module itself
|
Thanks @cherryleafroad ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new light theme and updated the example to be able to switch between both